[SDK] fix: show token + dollar values for wallet balances #6240
+88
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
changed the title
joaquim-verges
force-pushed
the
_SDK_fix_Hide_dollar_values_for_wallet_balances
branch
from
f9e54a0 to
e60ec1f
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/WalletSelectorButton.tsx
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/WalletSelectorButton.tsx
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6240 +/- ##
==========================================
- Coverage 56.88% 56.87% -0.02%
==========================================
Files 1166 1166
Lines 64507 64522 +15
Branches 5226 5226
==========================================
+ Hits 36698 36699 +1
- Misses 27081 27095 +14
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
_SDK_fix_Hide_dollar_values_for_wallet_balances
branch
from
e60ec1f to
b361944
Compare
🦋 Changeset detectedLatest commit: ff01471 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joaquim-verges
force-pushed
the
_SDK_fix_Hide_dollar_values_for_wallet_balances
branch
from
b361944 to
ff01471
Compare
joaquim-verges
deleted the
_SDK_fix_Hide_dollar_values_for_wallet_balances
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the user interface for wallet balance display and enhancing the documentation for the
canClaimfunction across multiple token standards.Detailed summary
BuyTokenInput.tsxto adjust the styling of theContainercomponent.FiatValuereturn logic to avoid displaying a placeholder when no data is available.canClaimfunction inerc20,erc721, anderc1155extensions.TokenBalanceRowinWalletSelectorButton.tsxto format token balances and adjust layout.